Skip to content

INTMDB-142: Fixes the bug for alertconfiguration using data dog #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2021
Merged

INTMDB-142: Fixes the bug for alertconfiguration using data dog #366

merged 2 commits into from
Jan 5, 2021

Conversation

coderGo93
Copy link
Contributor

Description

Fixes the bug of alert configuration using data dog by changing the name of struct.
Added acceptance tests for the case:

  • TestAccResourceMongoDBAtlasAlertConfiguration_DataDog

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Dec 18, 2020
themantissa
themantissa requested changes Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions I want to be sure on first. Thanks!

themantissa
themantissa approved these changes Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please ensure a DoU review as well

marinsalinas
marinsalinas approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Nice catch!

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Jan 5, 2021
@coderGo93 coderGo93 merged commit 60b4bca into master Jan 5, 2021
@coderGo93 coderGo93 deleted the INTMDB-142 branch January 5, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa approved these changes

@leofigy leofigy Awaiting requested review from leofigy

Assignees

@coderGo93 coderGo93

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderGo93 @marinsalinas @themantissa