Skip to content

update the documentation and examples for adding the replication spec… #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2020
Merged

update the documentation and examples for adding the replication spec… #357

merged 3 commits into from
Dec 8, 2020

Conversation

nikhil-mongo
Copy link
Collaborator

@nikhil-mongo nikhil-mongo commented Nov 27, 2020 •
edited
Loading

update the documentation and examples for adding the replication spec…s rather than the replication factor as it is deprecated

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s): #356

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@nikhil-mongo
update the documentation and examples for adding the replication spec…
56a3a7a 
…s rather than the replication factor as it is deprecated
themantissa
themantissa requested changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Thanks!

@nikhil-mongo
Copy link
Collaborator Author

All the issues have been fixed as per the comments.

themantissa
themantissa approved these changes Dec 8, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you

@themantissa themantissa merged commit fb3e8da into mongodb:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhil-mongo @themantissa