AWS and AZURE Private Endpoints (INTMDB-123 & INTMDB-124) #349

coderGo93 · 2020-11-13T00:16:11Z

Description

Resources, datasources and its tests of private endpoints has been migrated
Created files for deprecated private endpoints

Link to any related issue(s):

Type of change:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the Terraform contribution guidelines
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code

Further comments

leofigy · 2020-11-13T00:56:48Z

It's looking good, just fix the linting

…ated

themantissa · 2020-11-18T23:16:02Z

@leofigy and @coderGo93 I'm concerned with how the deprecation is being performed here, it seems to be simply a rename of the existing resource and creating a new one, this gives no time for existing AWS privatelink users to transition from the old resource/datasource to the new (i.e. following https://www.terraform.io/docs/extend/best-practices/deprecations.html#provider-data-source-or-resource-removal) Am I mis-understanding?

coderGo93 · 2020-11-18T23:32:54Z

Thanks for the eye, @themantissa , forgot to add that deprecate messages, will do that

coderGo93 · 2020-11-19T02:32:43Z

Hi @leofigy , just made changes with renamed after discussing with @themantissa , did testing about importing with new resource from old resource and it works for me

leofigy · 2020-11-19T20:07:05Z

LGTM

themantissa

Some minor changes but I think over all looks really good!

themantissa · 2020-11-18T22:28:46Z

examples/azure-atlas-privatelink/Readme.md

@@ -0,0 +1,81 @@
+# Example - Microsoft Azure and MongoDB Atlas Private Endpoint


Well this is surprising! We have had some internal team members adding examples and while this is useful was not technically in scope for the ticket. We can do more of these during development if we are able to get more hours and if we do the actual addition work first and then add the example. For now I do want to recognize that you saw what we've been doing and followed the example and I truly applaud and appreciate that but please try to keep in the scoped work till we can add on time for example generation :)

themantissa · 2020-11-18T22:53:27Z

examples/azure-atlas-privatelink/main.tf

+  endpoint_service_id = mongodbatlas_private_endpoint.test.private_link_id
+  private_endpoint_ip_address = azurerm_private_endpoint.test.private_service_connection.0.private_ip_address
+  provider_name = "AZURE"
+}


There's a couple of files giving the no newline warning so please add - some linters will pick those up

themantissa · 2020-11-19T23:44:05Z

mongodbatlas/data_source_mongodbatlas_private_endpoint_interface_link.go

@@ -42,6 +42,7 @@ func dataSourceMongoDBAtlasPrivateEndpointInterfaceLink() *schema.Resource {
 				Computed: true,
 			},
 		},
+		DeprecationMessage: "use mongodbatlas_privatelink_endpoint_service datasource instead",


Let's expand this a bit:
"this data source is deprecated, please transition as soon as possible to mongodbatlas_privatelink_endpoint_service",

themantissa · 2020-11-19T23:50:18Z

mongodbatlas/data_source_mongodbatlas_private_endpoint.go

@@ -43,6 +43,7 @@ func dataSourceMongoDBAtlasPrivateEndpoint() *schema.Resource {
 				Computed: true,
 			},
 		},
+		DeprecationMessage: "use mongodbatlas_privatelink_endpoint datasource instead",


Expanding out a bit "this data source is deprecated, please transition as soon as possible to mongodbatlas_privatelink_endpoint_service",

themantissa · 2020-11-19T23:52:49Z

mongodbatlas/resource_mongodbatlas_private_endpoint.go

@@ -71,19 +71,20 @@ func resourceMongoDBAtlasPrivateEndpoint() *schema.Resource {
 				Computed: true,
 			},
 		},
+		DeprecationMessage: "use mongodbatlas_privatelink_endpoint resource instead",


"this resource is deprecated, please transition as soon as possible to mongodbatlas_privatelink_endpoint",

themantissa · 2020-11-20T00:01:53Z

website/docs/d/privatelink_endpoint.html.markdown

+* `provider_name` - (Required) Cloud provider for which you want to retrieve a private endpoint service. Atlas accepts `AWS` or `AZURE`.
+
+
+## Attributes Reference


I think this may be missing the Azure attributes (there are two tabs in the api docs, one with AWS and one with azure)

website/docs/d/privatelink_endpoint_service.html.markdown

website/docs/r/private_endpoint_interface_link.html.markdown

themantissa · 2020-11-20T00:12:39Z

website/docs/r/privatelink_endpoint.html.markdown

+* `project_id` - Required 	Unique identifier for the project.
+* `providerName` - (Required) Name of the cloud provider for which you want to create the private endpoint service. Atlas accepts `AWS` or `AZURE`.
+* `region` - (Required) Cloud provider region in which you want to create the private endpoint connection.
+Accepted values are:


We have had a hard time keeping these updated so please just link to the api doc for these, for example:
Updated accepted values can found in the main API documentation: MongoDB API Private Endpoint Service

themantissa · 2020-11-20T00:13:59Z

website/docs/r/privatelink_endpoint_service.html.markdown

+* `provider_name` - (Required) Cloud provider for which you want to create a private endpoint. Atlas accepts `AWS` or `AZURE`.
+* `private_endpoint_ip_address` - (Optional) Private IP address of the private endpoint network interface you created in your Azure VNet. Only for `AZURE`.
+
+## Attributes Reference


Need to be sure to include which are for AWS and which for Azure.

themantissa · 2020-11-20T00:15:52Z

@coderGo93 can you share with me the steps to you did to move from old to new in your test and I'll write up a guide. @shum added you to just give it a look since you were close to this one.

coderGo93 · 2020-11-20T01:12:52Z

Hi @themantissa , for steps to import from old to new are like this:

For PrivateLink Endpoint can be read in README.md

Terraform import terraform import mongodbatlas_privatelink_endpoint.test {project_id}-{private_link_id}-{provider_name}
i.e: terraform import mongodbatlas_privatelink_endpoint.test 1112222b3bf99403840e8934-3242342343112-AWS

For PrivateLink Endpoint Service

Terraform import mongodbatlas_privatelink_endpoint_service.test {project_id}--{private_link_id}--{endpoint_service_id}--{provider_name}
i.e: terraform import mongodbatlas_privatelink_endpoint_service.test terraform import mongodbatlas_privatelink_endpoint_service.test 1112222b3bf99403840e8934--vpce-4242342343--3242342343112--AWS

NOTE: Provider name for both resources are case sensitive.

Once done it should appear the info of imported resource with terraform show.

themantissa

LGTM - thanks @coderGo93 for the fixes. Let's just have @shum take a quick look and we are good.

themantissa · 2020-11-20T23:03:55Z

Hi @themantissa , for steps to import from old to new are like this:

For PrivateLink Endpoint can be read in README.md
1. Terraform import `terraform import mongodbatlas_privatelink_endpoint.test {project_id}-{private_link_id}-{provider_name} `
   i.e: `terraform import mongodbatlas_privatelink_endpoint.test 1112222b3bf99403840e8934-3242342343112-AWS`
For PrivateLink Endpoint Service
1. Terraform import `mongodbatlas_privatelink_endpoint_service.test {project_id}--{private_link_id}--{endpoint_service_id}--{provider_name} `
   i.e: `terraform import mongodbatlas_privatelink_endpoint_service.test terraform import mongodbatlas_privatelink_endpoint_service.test 1112222b3bf99403840e8934--vpce-4242342343--3242342343112--AWS`
NOTE: Provider name for both resources are case sensitive.

Once done it should appear the info of imported resource with terraform show.

@coderGo93 but you first need to remove them from terraform state with the old resource, correct? and thanks for including here.

coderGo93 · 2020-11-21T00:46:05Z

@themantissa That's correct, you need to remove first the terraform state otherwise it will say it already has info or something like that IIRC

shum

Generally LGTM. A few comments. Will review again after Thanksgiving!

shum · 2020-11-24T23:58:28Z

examples/azure-atlas-privatelink/variables.tf

+}
+
+variable "subscription_id" {
+  default = "AZURE SUSCRIPTION ID"


Suggested change

default = "AZURE SUSCRIPTION ID"

default = "AZURE SUBSCRIPTION ID"

shum · 2020-11-25T00:00:07Z

mongodbatlas/data_source_mongodbatlas_cloud_provider_access.go

+	errorGetRead = "error reading cloud provider access %s"
+)
+
+func dataSourceMongoDBAtlasCloudProviderAccessList() *schema.Resource {


This reads like it would have been a part of INTMDB-131 - is this intentional?

is it? @leofigy

It's weird, I did a PR but it was to grab your changes into my branch #353, because I needed your changes because you changed the client. I did a commit right now to remove the provider access files

shum · 2020-11-25T23:40:22Z

mongodbatlas/resource_mongodbatlas_cloud_provider_access.go

+
+const (
+	errorCloudProviderAccessCreate   = "error creating cloud provider access %s"
+	errorCloudProviderAccessUpdate   = "error update cloud provider access %s"


Suggested change

errorCloudProviderAccessUpdate = "error update cloud provider access %s"

errorCloudProviderAccessUpdate = "error updating cloud provider access %s"

shum · 2020-11-25T23:40:30Z

mongodbatlas/resource_mongodbatlas_cloud_provider_access.go

+const (
+	errorCloudProviderAccessCreate   = "error creating cloud provider access %s"
+	errorCloudProviderAccessUpdate   = "error update cloud provider access %s"
+	errorCloudProviderAccessDelete   = "error delete cloud provider access %s"


Suggested change

errorCloudProviderAccessDelete = "error delete cloud provider access %s"

errorCloudProviderAccessDelete = "error deleting cloud provider access %s"

shum · 2020-11-25T23:40:45Z

mongodbatlas/resource_mongodbatlas_cloud_provider_access.go

+	errorCloudProviderAccessCreate   = "error creating cloud provider access %s"
+	errorCloudProviderAccessUpdate   = "error update cloud provider access %s"
+	errorCloudProviderAccessDelete   = "error delete cloud provider access %s"
+	errorCloudProviderAccessImporter = "error in import for cloud provider access %s"


Suggested change

errorCloudProviderAccessImporter = "error in import for cloud provider access %s"

errorCloudProviderAccessImporter = "error importing cloud provider access %s"

shum · 2020-11-25T23:43:05Z

mongodbatlas/resource_mongodbatlas_cloud_provider_access.go

+	errorCloudProviderAccessImporter = "error in import for cloud provider access %s"
+)
+
+func resourceMongoDBAtlasCloudProviderAccess() *schema.Resource {


This again, looks like INTMDB-131 - intentional? I will ignore for now.

shum

Actually, I don't have any blocking comments on the actual private endpoint changes. If we can remove the cloud_provider_access files, I think we're good to go.

…ider-mongodbatlas into private-endpoints

Edgar Lopez added 3 commits November 12, 2020 17:10

chore: updated vendor local client

e2b7591

migrated from deprecated to actual version for private endpoints

953ddc5

deprecated private endpoints

a383e14

leofigy added 3 commits November 12, 2020 21:15

Cloud provider client

508e6b6

cloud provider client code

c3ea2e9

schema definition for read

6c90e46

coderGo93 changed the title ~~WIP: INTMDB-123 and INTMDB-124~~ WIP: AWS and AZURE Private Endpoints (INTMDB-123 & INTMDB-124) Nov 13, 2020

Edgar López added 8 commits November 13, 2020 17:45

added docs for private points

59670a6

added docs for private points

96475fe

refactor: changed order for parameters

1a622cd

test: changed config

4d53cfb

refactor: changed the way it imports

f884ff6

tests: deleted config for azure testacc for azure provider issues rel…

307c09d

…ated

test: added a folder example with config tf for azure endpoint

549f963

chore: updated vendor from mongodb local master

c87f2f3

coderGo93 changed the title ~~WIP: AWS and AZURE Private Endpoints (INTMDB-123 & INTMDB-124)~~ AWS and AZURE Private Endpoints (INTMDB-123 & INTMDB-124) Nov 17, 2020

coderGo93 requested review from leofigy and themantissa November 17, 2020 18:23

coderGo93 self-assigned this Nov 17, 2020

Edgar López and others added 6 commits November 17, 2020 14:59

test: fixed config tf

37ea3ab

fix: encoded url path for get one private endpoint

c155b6e

fix: encoded url path for deletet one private endpoint

becf181

test: changed hardcoded resource group name to variable(dinamic)

ddc2993

skeleton for read

db39469

read function list code

2c32bd8

Edgar López added 2 commits November 18, 2020 16:47

refactor: added deprecated message

07d829a

docs: added deprecated message

8f9f05a

test: renamed new resource

5a18213

coderGo93 requested a review from leofigy November 19, 2020 02:31

leofigy and others added 5 commits November 18, 2020 23:12

adding create and resource

bb8f6b5

fixing the id

6842f09

awful read function

6befd74

fixing linting

28f9d0f

fix: fixes a bug in datasource privatelink endpoint service

7102724

leofigy approved these changes Nov 19, 2020

View reviewed changes

themantissa requested changes Nov 20, 2020

View reviewed changes

themantissa requested a review from shum November 20, 2020 00:14

refactor: made changes suggested by melissa

4f2f94f

coderGo93 requested a review from themantissa November 20, 2020 01:04

resource update, delete and import

4998b4e

themantissa approved these changes Nov 20, 2020

View reviewed changes

Merge branch 'INTMDB-131' into private-endpoints

97e1a42

shum requested changes Nov 25, 2020

View reviewed changes

shum approved these changes Nov 25, 2020

View reviewed changes

Edgar López and others added 3 commits November 25, 2020 16:55

refactor: fixes a typo

122980f

Merge branch 'private-endpoints' of github.com:mongodb/terraform-prov…

f85aeba

…ider-mongodbatlas into private-endpoints

clean-up

1b3e120

coderGo93 added the run-testacc To run acceptance tests label Nov 26, 2020

coderGo93 merged commit da0b336 into master Nov 26, 2020

coderGo93 deleted the private-endpoints branch November 26, 2020 02:47

AntjeRadkiewicz1337 mentioned this pull request Feb 9, 2021

mongodbatlas_private_endpoint and mongodbatlas_private_endpoint_interface_link not working as expected in version 0.7 #406

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AWS and AZURE Private Endpoints (INTMDB-123 & INTMDB-124) #349

AWS and AZURE Private Endpoints (INTMDB-123 & INTMDB-124) #349

coderGo93 commented Nov 13, 2020 •

edited

Loading

leofigy commented Nov 13, 2020

themantissa commented Nov 18, 2020

coderGo93 commented Nov 18, 2020

coderGo93 commented Nov 19, 2020

leofigy commented Nov 19, 2020

themantissa left a comment

themantissa Nov 18, 2020

themantissa Nov 18, 2020

themantissa Nov 19, 2020

themantissa Nov 19, 2020

themantissa Nov 19, 2020

themantissa Nov 20, 2020

themantissa Nov 20, 2020

themantissa Nov 20, 2020

themantissa commented Nov 20, 2020

coderGo93 commented Nov 20, 2020

themantissa left a comment

themantissa commented Nov 20, 2020

coderGo93 commented Nov 21, 2020

shum left a comment

shum Nov 24, 2020

shum Nov 25, 2020

coderGo93 Nov 25, 2020

leofigy Nov 26, 2020

shum Nov 25, 2020

shum Nov 25, 2020

shum Nov 25, 2020

shum Nov 25, 2020

shum left a comment

		@@ -0,0 +1,81 @@
		# Example - Microsoft Azure and MongoDB Atlas Private Endpoint

		* `provider_name` - (Required) Cloud provider for which you want to retrieve a private endpoint service. Atlas accepts `AWS` or `AZURE`.


		## Attributes Reference

	default = "AZURE SUSCRIPTION ID"
	default = "AZURE SUBSCRIPTION ID"

	errorCloudProviderAccessUpdate = "error update cloud provider access %s"
	errorCloudProviderAccessUpdate = "error updating cloud provider access %s"

	errorCloudProviderAccessDelete = "error delete cloud provider access %s"
	errorCloudProviderAccessDelete = "error deleting cloud provider access %s"

	errorCloudProviderAccessImporter = "error in import for cloud provider access %s"
	errorCloudProviderAccessImporter = "error importing cloud provider access %s"

AWS and AZURE Private Endpoints (INTMDB-123 & INTMDB-124) #349

AWS and AZURE Private Endpoints (INTMDB-123 & INTMDB-124) #349

Conversation

coderGo93 commented Nov 13, 2020 • edited Loading

Description

Type of change:

Required Checklist:

Further comments

leofigy commented Nov 13, 2020

themantissa commented Nov 18, 2020

coderGo93 commented Nov 18, 2020

coderGo93 commented Nov 19, 2020

leofigy commented Nov 19, 2020

themantissa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

themantissa commented Nov 20, 2020

coderGo93 commented Nov 20, 2020

themantissa left a comment

Choose a reason for hiding this comment

themantissa commented Nov 20, 2020

coderGo93 commented Nov 21, 2020

shum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shum left a comment

Choose a reason for hiding this comment

coderGo93 commented Nov 13, 2020 •

edited

Loading