documentation fix #335 and examples added for the Azure VNET peering and AWS Private Link #340
Conversation
|
@nikhil-mongo I'll review this as is but in the future:
|
There was a problem hiding this comment.
@nikhil-mongo left a few non blocking comments for next time you submit a PR. A great start of examples and appreciated!
| replication_factor = 3 | ||
| provider_backup_enabled = true | ||
| auto_scaling_disk_gb_enabled = true | ||
| mongo_db_major_version = "4.2" |
There was a problem hiding this comment.
Just for next time we may want to start using 4.4 in examples.
| } | ||
| output "plstring" { | ||
| value = lookup(mongodbatlas_cluster.cluster-atlas.connection_strings[0].aws_private_link_srv, aws_vpc_endpoint.ptfe_service.id) | ||
| } |
There was a problem hiding this comment.
Most linters will comment if you don't have a final newline, not blocking but fyi.
| name_prefix = "default-" | ||
| description = "Default security group for all instances in ${aws_vpc.primary.id}" | ||
| vpc_id = aws_vpc.primary.id | ||
| ingress { |
There was a problem hiding this comment.
I would lean towards providing more locked down examples or add a comment to be sure to narrow ranges, blocks, etc. Fine for now but if you'd like to submit a 2nd PR based on this input that would be fine. No rush.
| @@ -0,0 +1,32 @@ | |||
| variable "public_key" { | |||
| description = "The public API key for MongoDB Atlas" | |||
There was a problem hiding this comment.
Normally when I include any secrets I remind folks it's better to use a secret manager, etc and to be sure to git ignore any variables files in as many places as possible. Again not a blocker but a nice-to-do for, especially new, users
| @@ -8,7 +8,7 @@ description: |- | |||
|
|
|||
| # mongodbatlas_private_endpoint_link | |||
|
|
|||
| `mongodbatlas_private_endpoint_link` describe a Private Endpoint Link. This represents a Private Endpoint Link Connection that wants to retrieve details in an Atlas project. | |||
| `mongodbatlas_private_endpoint_interface_link` describe a Private Endpoint Link. This represents a Private Endpoint Link Connection that wants to retrieve details in an Atlas project. | |||
There was a problem hiding this comment.
lol I fixed the resource and missed the datasource! Nice catch, ty!
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments
documentation fix #335 and examples added for the Azure VNET peering and AWS Private Link