Skip to content

mongodbatlas_alert_configuration - reset ID if was deleted and it's already in the plan #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

mongodbatlas_alert_configuration - reset ID if was deleted and it's already in the plan #333

merged 1 commit into from
Oct 20, 2020

Conversation

leofigy
Copy link
Contributor

@leofigy leofigy commented Oct 17, 2020

Description

Fix for #305
The root cause is that we were not handling the case where the resource was already created, and resetting the id, to allow terraform to mark it as an Add in the plan/apply

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@leofigy leofigy self-assigned this Oct 17, 2020
@leofigy leofigy added the run-testacc To run acceptance tests label Oct 17, 2020
marinsalinas
marinsalinas approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM!

themantissa
themantissa approved these changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch.

@leofigy leofigy merged commit 5ff01d4 into master Oct 20, 2020
@leofigy leofigy deleted the issue-305 branch October 20, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees

@leofigy leofigy

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leofigy @marinsalinas @themantissa