fix: Fixes JSON comparison in audit_filter field in mongodbatlas_auditing
#3302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APIx bot: a message has been sent to Docs Slack channel |
lantoli
reviewed
Apr 25, 2025
lantoli
reviewed
Apr 25, 2025
| @@ -150,3 +152,7 @@ func resourceDelete(ctx context.Context, d *schema.ResourceData, meta any) diag. | |||
| d.SetId("") | |||
| return nil | |||
| } | |||
|
|
|||
| func diffSuppressJSON(k, old, newStr string, d *schema.ResourceData) bool { | |||
There was a problem hiding this comment.
can we update/add an acc test that would fail before this change?
There was a problem hiding this comment.
done in 1d4e78a
Also, you can see failing tests if there is no DiffSuppressFunc: diffSuppressJSON,
lantoli
approved these changes
Apr 25, 2025
kanchana-mongodb
approved these changes
Apr 25, 2025
lantoli
approved these changes
Apr 25, 2025
EspenAlbert
reviewed
Apr 25, 2025
| @@ -31,10 +40,15 @@ func TestAccGenericAuditing_basic(t *testing.T) { | |||
| { | |||
| Config: configBasic(projectID, auditFilter, true, true), | |||
| Check: resource.ComposeAggregateTestCheckFunc(checks(auditFilter, true, true)...), | |||
| ConfigPlanChecks: resource.ConfigPlanChecks{ | |||
There was a problem hiding this comment.
[nit] I guess this explicit check is necessary because it is a SDKv2 resource? Maybe add a comment why
There was a problem hiding this comment.
not really necessary now that I think about it. Removed in 76582ca
EspenAlbert
reviewed
Apr 25, 2025
| @@ -89,18 +103,23 @@ func importStateIDFunc(resourceName string) resource.ImportStateIdFunc { | |||
| } | |||
|
|
|||
| func configBasic(projectID, auditFilter string, auditAuth, enabled bool) string { | |||
| filterValue := fmt.Sprintf("%q", auditFilter) | |||
| if auditFilter != "{}" { | |||
There was a problem hiding this comment.
[nit] use previous var? emptyAuditFilter?
There was a problem hiding this comment.
thanks, done in 40750dc
EspenAlbert
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes JSON comparison in
audit_filterfield inmongodbatlas_auditingLink to any related issue(s): CLOUDP-315476 & HELP-74398
Type of change:
Required Checklist:
Further comments