Skip to content

feat: Update Resource Policy resource to GA #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

feat: Update Resource Policy resource to GA #3276

merged 4 commits into from
Apr 15, 2025

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Apr 11, 2025 •
edited
Loading

Description

Update Resource Policy resource to GA

Link to any related issue(s): CLOUDP-311360

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@maastha maastha marked this pull request as ready for review April 14, 2025 09:46
@maastha maastha requested review from a team as code owners April 14, 2025 09:46
@github-actions GitHub Actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

marcosuma
marcosuma approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I am guessing we can now also do https://jira.mongodb.org/browse/CLOUDP-282801? cc @lantoli
if so, let's put it in our RFW.

@maastha maastha changed the title feat: Update Resource Policy resource to GA feat: Update Resource Policy resource to GA - to be merged after upstream GA Apr 14, 2025
@maastha
Copy link
Collaborator Author

maastha commented Apr 14, 2025

Thank you! I am guessing we can now also do https://jira.mongodb.org/browse/CLOUDP-282801? cc @lantoli
if so, let's put it in our RFW.

@marcosuma yes that should be okay. Also left some questions on that ticket for @lantoli

lantoli
lantoli reviewed Apr 14, 2025
View reviewed changes
lantoli
lantoli reviewed Apr 14, 2025
View reviewed changes
.github/workflows/acceptance-tests-runner.yml
@@ -984,7 +984,6 @@ jobs:
MONGODB_ATLAS_PUBLIC_KEY: ${{ secrets.mongodb_atlas_rp_public_key }}
MONGODB_ATLAS_PRIVATE_KEY: ${{ secrets.mongodb_atlas_rp_private_key }}
MONGODB_ATLAS_LAST_VERSION: ${{ needs.get-provider-version.outputs.provider_version }}
MONGODB_ATLAS_ENABLE_PREVIEW: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's not used anywhere anymore?

lantoli
lantoli reviewed Apr 14, 2025
View reviewed changes
internal/provider/provider.go
resourcepolicy.DataSource,
resourcepolicy.PluralDataSource,
} // Data sources not yet in GA
previewDataSources := []func() datasource.DataSource{} // Data sources not yet in GA
Copy link
Member

@lantoli lantoli Apr 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also delete providerEnablePreview, providerEnablePreview and any other supporting code that is not needed anymore?

edit: it can be done in CLOUDP-282801

EspenAlbert
EspenAlbert approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have we done this for CFN?

@maastha
Copy link
Collaborator Author

maastha commented Apr 15, 2025

Thanks! Have we done this for CFN?

Not yet

@maastha maastha merged commit a9e6cd7 into master Apr 15, 2025
40 checks passed
@maastha maastha deleted the CLOUDP-311360-rp-ga branch April 15, 2025 15:00
svc-apix-Bot added a commit that referenced this pull request Apr 15, 2025
@svc-apix-Bot
chore: Updates CHANGELOG.md for #3276
b53fccc
@maastha maastha changed the title feat: Update Resource Policy resource to GA - to be merged after upstream GA feat: Update Resource Policy resource to GA Apr 15, 2025
@AgustinBettati AgustinBettati mentioned this pull request Apr 16, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli lantoli approved these changes

@EspenAlbert EspenAlbert EspenAlbert approved these changes

@marcosuma marcosuma marcosuma approved these changes

@jvincent-mongodb jvincent-mongodb jvincent-mongodb approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maastha @lantoli @EspenAlbert @marcosuma @jvincent-mongodb @svc-apix-Bot