Skip to content

chore: Remove generation of ObjType models in resource generation #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2025

Conversation

AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Apr 11, 2025

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s): CLOUDP-312316

As of current findings conversion logic will not require having ObjType definitions for nested attribute schemas. This PR removes ObjType generation when running make generate-resource. Complete code generation logic is not removed as ObjType rendering can be useful for resources which are developed with standard TPF conversion functions.

This enables generating mongodbatlas_custom_db_role_api which before was facing a compilation error in ObjType generation.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@AgustinBettati AgustinBettati marked this pull request as ready for review April 11, 2025 15:37
@AgustinBettati AgustinBettati requested a review from a team as a code owner April 11, 2025 15:37
@AgustinBettati AgustinBettati merged commit 9d72367 into CLOUDP-301808-poc-autogeneration Apr 14, 2025
57 checks passed
@AgustinBettati AgustinBettati deleted the CLOUDP-312316 branch April 14, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants