Skip to content

feat: Adds protected_hours and time_zone_id to mongodbatlas_maintenance_window #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 24, 2025

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Mar 21, 2025

Description

Adds protected_hours and time_zone_id to mongodbatlas_maintenance_window

Link to any related issue(s): CLOUDP-291819

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Mar 27, 2025
@github-actions github-actions bot closed this Mar 30, 2025
@EspenAlbert EspenAlbert reopened this Apr 21, 2025
@EspenAlbert EspenAlbert added the not_stale Not stale issue or PR label Apr 21, 2025
@EspenAlbert EspenAlbert changed the title feat: Cloudp 291819 maintenance window feat: Adds protected_hours and time_zone_id to mongodbatlas_maintenance_window Apr 21, 2025
@EspenAlbert EspenAlbert marked this pull request as ready for review April 21, 2025 18:38
@EspenAlbert EspenAlbert requested review from a team as code owners April 21, 2025 18:38
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

Copy link
Contributor

@kanchana-mongodb kanchana-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -44,4 +44,12 @@ In addition to all arguments above, the following attributes are exported:
* `start_asap` - Flag indicating whether project maintenance has been directed to start immediately. If you request that maintenance begin immediately, this field returns true from the time the request was made until the time the maintenance event completes.
* `number_of_deferrals` - Number of times the current maintenance event for this project has been deferred, there can be a maximum of 2 deferrals.
* `auto_defer_once_enabled` - Flag that indicates whether you want to defer all maintenance windows one week they would be triggered.
* `protected_hours` - (Optional) Defines the time period during which there will be no standard updates to the clusters. See [Protected Hours](#protected-hours).
Copy link
Member

@lantoli lantoli Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we document the default protected hours value if not specified? is it 0,0 the default?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I asked on the ticket.
My guess is that it will be empty (no protected hours)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I don't know if there is a limit, e.g. can you set the 24h as protected? (i guess not because then maintenance can't happen). maybe we can reference some official doc for more info.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a link 20 lines below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks, and the answer is there: The length of your protected hours window cannot exceed 18 hours.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream replied that they have an internal default.

@EspenAlbert EspenAlbert merged commit 2c9ff26 into master Apr 24, 2025
40 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-291819-maintenance-window branch April 24, 2025 07:32
svc-apix-Bot added a commit that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants