Skip to content

changed from running on PR to manually trigger acceptance tests #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 28, 2020
Merged

changed from running on PR to manually trigger acceptance tests #319

merged 5 commits into from
Sep 28, 2020

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Sep 25, 2020 •
edited
Loading

Description

Modified the yaml where the acceptances tests will be run if the PR has a label called run-testacc and the person it's a collaborator.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Sep 25, 2020
@coderGo93 coderGo93 changed the title changed from running on PR to manually trigger acceptance tests WIP.changed from running on PR to manually trigger acceptance tests Sep 25, 2020
@coderGo93 coderGo93 changed the title WIP.changed from running on PR to manually trigger acceptance tests WIP: changed from running on PR to manually trigger acceptance tests Sep 25, 2020
@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Sep 25, 2020
@coderGo93 coderGo93 changed the title WIP: changed from running on PR to manually trigger acceptance tests changed from running on PR to manually trigger acceptance tests Sep 25, 2020
@coderGo93 coderGo93 removed the run-testacc To run acceptance tests label Sep 25, 2020
themantissa
themantissa approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please have another DoU dev give it a look too before merge :)

@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Sep 25, 2020
leofigy
leofigy approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@coderGo93 coderGo93 merged commit 2f81870 into master Sep 28, 2020
@themantissa themantissa deleted the modify-yml-testacc branch August 10, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@leofigy leofigy leofigy approved these changes

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

Assignees

@coderGo93 coderGo93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderGo93 @themantissa @leofigy