Skip to content

feat: Add error_message, provider_account_id, and interface_endpoint_name to Stream PrivateLinkEndpoint models #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

tcannon91
Copy link
Collaborator

@tcannon91 tcannon91 commented Mar 7, 2025

Description

Add fields that exist in the Atlas Admin API for Streams PrivateLink Endpoints (error_message, provider_account_id, interface_endpoint_name). Also improve validation around the vendor and provider_name fields to fail faster (during planning) rather than waiting until getting a response from the API that is inconsistent with potential passed in values.

Link to any related issue(s):
https://jira.mongodb.org/browse/CLOUDP-301851

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

…point_name` to Stream PrivateLinkEndpoint models and improve validation against `provider_name` and `vendor` fields
@tcannon91 tcannon91 requested a review from a team as a code owner March 7, 2025 20:53
@tcannon91 tcannon91 requested a review from a team as a code owner March 7, 2025 20:56
@tcannon91 tcannon91 changed the title feat!: Add error_message, provider_account_id, and interface_endpoint_name to Stream PrivateLinkEndpoint models and improve validation against provider_name and vendor fields feat: Add error_message, provider_account_id, and interface_endpoint_name to Stream PrivateLinkEndpoint models Mar 10, 2025
Copy link
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good to have another pair of eyes cc @oarbusi

@marcosuma
Copy link
Collaborator

@tcannon91 today we'll release 1.29 (ref). This change won't go in there but we're planning to release next week as well. For reference, this is the changelog file to see what it'll be released next

@tcannon91
Copy link
Collaborator Author

Created this PR within the mongodb repo rather than my fork: #3161

@tcannon91
Copy link
Collaborator Author

Closing in favor of: #3161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants