-
Notifications
You must be signed in to change notification settings - Fork 190
feat: Add error_message
, provider_account_id
, and interface_endpoint_name
to Stream PrivateLinkEndpoint models
#3139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…point_name` to Stream PrivateLinkEndpoint models and improve validation against `provider_name` and `vendor` fields
error_message
, provider_account_id
, and interface_endpoint_name
to Stream PrivateLinkEndpoint models and improve validation against provider_name
and vendor
fieldserror_message
, provider_account_id
, and interface_endpoint_name
to Stream PrivateLinkEndpoint models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - good to have another pair of eyes cc @oarbusi
@tcannon91 today we'll release 1.29 (ref). This change won't go in there but we're planning to release next week as well. For reference, this is the changelog file to see what it'll be released next |
Created this PR within the mongodb repo rather than my fork: #3161 |
Closing in favor of: #3161 |
Description
Add fields that exist in the Atlas Admin API for Streams PrivateLink Endpoints (error_message, provider_account_id, interface_endpoint_name). Also improve validation around the vendor and provider_name fields to fail faster (during planning) rather than waiting until getting a response from the API that is inconsistent with potential passed in values.
Link to any related issue(s):
https://jira.mongodb.org/browse/CLOUDP-301851
Type of change:
Required Checklist: