Skip to content

fix: added a validation for restore_window_days #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2020
Merged

fix: added a validation for restore_window_days #300

merged 1 commit into from
Aug 27, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Aug 27, 2020 •
edited
Loading

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s): #290

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

themantissa
themantissa approved these changes Aug 27, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coderGo93
coderGo93 approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PacoDw PacoDw merged commit bd18b59 into master Aug 27, 2020
@PacoDw PacoDw deleted the fix-#290 branch August 27, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@coderGo93 coderGo93 coderGo93 approved these changes

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PacoDw @themantissa @coderGo93