Fixes many testacc #296
Fixes many testacc #296
Conversation
|
@coderGo93 this needs #293 first correct? I'd prefer to wait to review till the tests are all working. |
|
@themantissa Not really because this testacc needs the GH actions, so I rebase in #293 from this branch and then run again with changes of this branch. |
|
@coderGo93 is this ready for a review now? |
|
@themantissa Yes, in #293 I rebased from here when I made changes here |
| @@ -76,7 +76,7 @@ func dataSourceMongoDBAtlasCloudProviderSnapshotRestoreJob() *schema.Resource { | |||
| Computed: true, | |||
| }, | |||
| "oplog_ts": { | |||
| Type: schema.TypeString, | |||
| Type: schema.TypeInt, | |||
There was a problem hiding this comment.
Was this a bug found?
There was a problem hiding this comment.
It was a typo it seems, it should have been Int since it gave me an error of type so I changed it
There was a problem hiding this comment.
In the underlying docs it's a string https://docs.atlas.mongodb.com/reference/api/cloud-backup/restore/create-one-restore-job/ so we may want to ensure it's not a bigger bug or a miss of something else.
There was a problem hiding this comment.
mm weird, to me appears is a integer for oplogTs
There was a problem hiding this comment.
Ignore previous comment - string in docs in both places. Could Terraform be storing the string as an int? Seems weird.
| } | ||
| return resource.NonRetryableError(fmt.Errorf(errorWhitelistDelete, err)) | ||
| } | ||
| return resource.RetryableError(fmt.Errorf(errorWhitelistDelete, "Whitelist still exists")) |
There was a problem hiding this comment.
Another bug? Just want to get an idea of the related fixes to the actual resources.
There was a problem hiding this comment.
Yes, it happens sometimes the error about an ip whitelist still exists, when an ip exists it should retry not another delete because for some reason it can fail and it should have another get to verify that, that's why I deleted Delete and retry instead.
There was a problem hiding this comment.
Yeah, still think that's a timing issue. Just note that in the PR description, for example - "Fixed: retryable error for IP Whitelist resource"
…hange to false in private ip mode to avoid error about deprecated and avoid lint errors
… instance scale and changed it back the region for container azure
…ort to rs primare attributes instead of decode state id
Description
Fixes many testacc, still not sure if everything will work until github actions works.
Fixed:
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments