Fix #279 #280 #294
Merged
Fix #279 #280 #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantissa
requested changes
Aug 17, 2020
languitar
reviewed
Aug 18, 2020
themantissa
approved these changes
Aug 19, 2020
…able to modify/remove them correctly
coderGo93
pushed a commit
that referenced
this pull request
Aug 21, 2020
* chore: changed the type of the inherited attribute to Set type to be able to modify/remove them correctly * chore: added a test case to validate the user error * chore: changed actions attribute as optional * chore: improved test case removing actions to validate that it can be ommiting * chore: updated go.mod and dependecies
coderGo93
pushed a commit
that referenced
this pull request
Aug 21, 2020
* chore: changed the type of the inherited attribute to Set type to be able to modify/remove them correctly * chore: added a test case to validate the user error * chore: changed actions attribute as optional * chore: improved test case removing actions to validate that it can be ommiting * chore: updated go.mod and dependecies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The inherited Roles attribute was changed to Set type to handle the best way when a user wants to remove/update inherited roles.
Link to any related issue(s): #279 #280
Type of change:
Required Checklist: