Skip to content

Correct cluster labels documentation #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Correct cluster labels documentation #286

merged 1 commit into from
Aug 17, 2020

Conversation

themantissa
Copy link
Collaborator

Description

Remove incorrect labels section and added example in cluster resource doc. Clarified in datasource doc.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • [X ] Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Remove incorrect labels section and added example in cluster resource doc. Clarified in datasource doc.
@themantissa themantissa requested a review from PacoDw August 7, 2020 17:50
@themantissa
Copy link
Collaborator Author

@PacoDw can you give this a look and see if it makes sense to you?

Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems nice, thanks 👍

@themantissa themantissa merged commit 230327a into master Aug 17, 2020
@themantissa themantissa deleted the docs-fix-labels branch August 19, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants