Skip to content

Add templates to repo #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 7, 2020
Merged

Add templates to repo #282

merged 6 commits into from
Aug 7, 2020

Conversation

themantissa
Copy link
Collaborator

Description

Add templates to make bug/issue/support easier to route correctly.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@themantissa
Add templates to repo
920528f 
Add templates to make bug/issue/support easier to route correctly.
@themantissa themantissa requested review from gssbzn and PacoDw August 6, 2020 01:02
gssbzn
gssbzn reviewed Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great I have a couple of suggestions on wording and sorting of some of the sections but nothing major

@themantissa
Copy link
Collaborator Author

@gssbzn thank you so much for the feedback. Will respond to each. Much of this is inline w/ what other providers have but you have some excellent points where we can break away from the pack!

themantissa and others added 5 commits August 6, 2020 17:05
@themantissa @gssbzn
Update .github/ISSUE_TEMPLATE/Bug_Report.md
338a6a1 
Accept edit suggestion.

Co-authored-by: Gustavo Bazan <[email protected]>
@themantissa @gssbzn
Update .github/ISSUE_TEMPLATE/Bug_Report.md
dbe4b3c 
Update text to more impactful wording

Co-authored-by: Gustavo Bazan <[email protected]>
@themantissa
Update Bug_Report.md
45bde53 
update link
@themantissa
Merge branch 'add-issue-templates' of https://github.com/mongodb/terr…
72b32ff 
…aform-provider-mongodbatlas into add-issue-templates
@themantissa
Update Bug_Report.md
75698ac 
Incorperate suggestions to improve flow and examples.
@themantissa themantissa requested a review from gssbzn August 6, 2020 22:27
gssbzn
gssbzn approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for all the improvements

@themantissa themantissa merged commit 1cb3470 into master Aug 7, 2020
@themantissa themantissa deleted the add-issue-templates branch August 19, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@PacoDw PacoDw Awaiting requested review from PacoDw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themantissa @gssbzn