-
Notifications
You must be signed in to change notification settings - Fork 190
fix: fix golangci lint and travis #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dist: xenial | ||
sudo: required | ||
services: | ||
- docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to allow your tests to run docker not to run the tests in docker so there's no point to enable it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thank you so much 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and very much appreciate the fixes!
Description
golangci-lint should not be installed from source, their docs advice against it , this seems to be failing already on travis on a separate PR
I'm also fixing some linting errors flagged now by the tool
And also simplifying how travis is configured, some of the travis fixes I'm bringing them from the go client repo
Type of change:
Required Checklist:
Further comments
Some linting errors where flagged around how some regex could be simplified, I'm relaying on unit testing of the functions to catch a the regex from breaking