Skip to content

fix: fix golangci lint and travis #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2020
Merged

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jul 21, 2020

Description

golangci-lint should not be installed from source, their docs advice against it , this seems to be failing already on travis on a separate PR

I'm also fixing some linting errors flagged now by the tool

And also simplifying how travis is configured, some of the travis fixes I'm bringing them from the go client repo

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Some linting errors where flagged around how some regex could be simplified, I'm relaying on unit testing of the functions to catch a the regex from breaking

@ghost ghost added the size/M label Jul 21, 2020
dist: xenial
sudo: required
services:
- docker
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to allow your tests to run docker not to run the tests in docker so there's no point to enable it

Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you so much 👍

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and very much appreciate the fixes!

@gssbzn gssbzn merged commit fe6dd62 into mongodb:master Jul 21, 2020
@gssbzn gssbzn deleted the fix-linting branch July 21, 2020 21:40
@gssbzn gssbzn mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants