Skip to content

fix: added validation for autoscaling compute enabled and when true a… #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

fix: added validation for autoscaling compute enabled and when true a… #267

merged 1 commit into from
Jul 21, 2020

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Jul 20, 2020 •
edited
Loading

…dd the parameter autoscaling to request and its test

Description

Fixes #265

The problem was sending autoclusting empty in request when creating, I validated it when it's enabled with autoscaling computed as the doc mentioned.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

fix: added validation for autoscaling compute enabled and when true a…
833caf6 
…dd the parameter autoscaling to request and its test
@coderGo93 coderGo93 self-assigned this Jul 20, 2020
@ghost ghost added the size/S label Jul 20, 2020
@themantissa themantissa mentioned this pull request Jul 21, 2020
Closed
themantissa
themantissa approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this morning and this seems to fix it so LGTM. Thank you!

PacoDw
PacoDw approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice

@coderGo93 coderGo93 merged commit 712fa81 into master Jul 21, 2020
@coderGo93 coderGo93 deleted the fix-265 branch July 21, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@PacoDw PacoDw PacoDw approved these changes

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

@gmlp gmlp Awaiting requested review from gmlp

Assignees

@coderGo93 coderGo93

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create a new cluster (M2/M5) after 0.6.2 version
3 participants
@coderGo93 @themantissa @PacoDw