Skip to content

fix: resource/project_ip_whitelist - modify ip whitelist entry valida… #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2020

Conversation

marinsalinas
Copy link
Contributor

…tion and fix acctest

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.
Closes #252

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

--- PASS: TestAccResourceMongoDBAtlasProjectIPWhitelist_SettingMultiple (139.76s)
PASS
coverage: 4.7% of statements
ok      github.com/terraform-providers/terraform-provider-mongodbatlas/mongodbatlas     (cached)        coverage: 4.7% of statements

@ghost ghost added the size/L label Jul 2, 2020
@ghost ghost added size/M and removed size/L labels Jul 2, 2020
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only needs to be fixed for travis check

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank your for staying on this one

@PacoDw PacoDw merged commit 479b4de into master Jul 13, 2020
@PacoDw PacoDw deleted the fix-252 branch July 13, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding 16 whitelist entries at the same time causes an error
4 participants