-
Notifications
You must be signed in to change notification settings - Fork 190
feat: Support replica_set_scaling_strategy
in mongodbatlas_advanced_cluster
#2539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a8a647e
wip: initial changes
oarbusi 37c87dd
Merge branch 'master' into CLOUDP-261476
oarbusi d286973
don't change cluster resource
oarbusi 555714a
changelog
oarbusi 2ac334d
Merge branch 'master' into CLOUDP-261476
oarbusi 01548c6
docs
oarbusi 7da52f3
Merge branch 'master' into CLOUDP-261476
oarbusi cc137eb
test
oarbusi d5fa943
specific test
oarbusi b8c5754
test and implement in old schema
oarbusi d8c0a48
separate tests for old and new schema
oarbusi b3a312a
fix update
oarbusi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
```release-note:enhancement | ||
resource/mongodbatlas_advanced_cluster: supports replica_set_scaling_strategy attribute | ||
``` | ||
|
||
```release-note:enhancement | ||
data-source/mongodbatlas_advanced_cluster: supports replica_set_scaling_strategy attribute | ||
``` | ||
|
||
```release-note:enhancement | ||
data-source/mongodbatlas_advanced_clusters: supports replica_set_scaling_strategy attribute | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the case of both data sources I believe we are only handling the case when the user defines
use_replication_spec_per_shard = true
, but if we want to handle all cases we should also consider the other path as done in the resource. Would suggest adjustingconfigReplicaSetScalingStrategyOldSchema
to use data source without this option so it is captured there as well.