Added golangci configuration and travis fix #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
PacoDw
force-pushed
the
golangci_conf
branch
2 times, most recently
from
e9842d2 to
385feb6
Compare
PacoDw
changed the title
gssbzn
reviewed
Jun 22, 2020
|
Just noting: Holding off on review until comments are addressed - seems we have a bit to adjust here first. Thanks! |
…ve clean code with good practices chore: removed gocognit lint
PacoDw
force-pushed
the
golangci_conf
branch
10 times, most recently
from
5c5ad46 to
e125578
Compare
PacoDw
changed the title
marinsalinas
suggested changes
Jul 7, 2020
marinsalinas
approved these changes
Jul 8, 2020
themantissa
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
LGTM - please ensure we wait for @gssbzn to check his comments were resolved and approves before merging.
|
@gssbzn could you check if it's okay plz? |
gssbzn
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented golangci.yml configuration file that will allow us to have more Lints for the code which helps to have more clean code and introduce good programming practices. Also, Travis was fixed.
Type of change:
Required Checklist: