Skip to content

feat: Supports new networking attribute in mongodbatlas_stream_connection #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Dec 23, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
6bcda86
support new networking attribute in stream connection
oarbusi Aug 2, 2024
f70fcd8
add changelog entry
oarbusi Aug 2, 2024
922f11a
fix unit tests
oarbusi Aug 2, 2024
08e8cec
documentation
oarbusi Aug 2, 2024
a0c05aa
fix migration tests
oarbusi Aug 2, 2024
12ac07c
include netwerking in examples for stream_connection
oarbusi Aug 2, 2024
e4c553d
improve changelog entry
oarbusi Aug 2, 2024
e31ff04
include acces.name attribute in model unit tests
oarbusi Aug 2, 2024
01884a2
fix: add PlanModifiers to avoid unexpected plan changes
EspenAlbert Aug 5, 2024
c459ae2
test: refactor the kafkaStreamConnectionConfig and use normal `mig.Cr…
EspenAlbert Aug 20, 2024
c666c96
test: refactor `testCaseCluster` and re-use in migration test
EspenAlbert Aug 20, 2024
7935642
test: improve check using actual name
EspenAlbert Aug 20, 2024
74a3e3e
chore: add revertable commit to avoid pending resources in CI
EspenAlbert Aug 20, 2024
fa4dc53
refactor: remove `networking.access.name` attribute (tests will fail …
EspenAlbert Aug 26, 2024
e4c2a82
chore: remove name also from data source schema
EspenAlbert Aug 26, 2024
a20d77a
test: fix wrong parameter for kafkaNetworking
EspenAlbert Aug 26, 2024
030c3c6
Merge branch 'master' into CLOUDP-265074
oarbusi Sep 18, 2024
41371ba
clean up test after merge
oarbusi Sep 18, 2024
2154b06
Merge branch 'master' into CLOUDP-265074
oarbusi Sep 27, 2024
0fb5a20
Merge branch 'master' into CLOUDP-265074
oarbusi Nov 27, 2024
5223618
Merge branch 'master' into CLOUDP-265074
EspenAlbert Dec 23, 2024
6f35f2a
move into var block
EspenAlbert Dec 23, 2024
0f965c5
address PR comments
EspenAlbert Dec 23, 2024
86e0e35
test: remove old sleep function from stream connection tests
EspenAlbert Dec 23, 2024
6a0aeec
test: refactor networking.access.type check to all test cases
EspenAlbert Dec 23, 2024
e49fa85
test: conditionally check networking.access.type based on provider ve…
EspenAlbert Dec 23, 2024
7fe005e
feat: implement DeleteStreamConnection with retry logic and add tests
EspenAlbert Dec 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
_ "embed"
"fmt"
"testing"
"time"

"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/terraform"
Expand Down Expand Up @@ -65,6 +66,10 @@ func testCaseKafkaPlaintext(t *testing.T) *resource.TestCase {
},
}
}
func DummySleep(*terraform.State) error {
time.Sleep(60 * time.Second)
return nil
}

func TestAccStreamRSStreamConnection_kafkaNetworkingVPC(t *testing.T) {
var (
Expand All @@ -86,7 +91,7 @@ func TestAccStreamRSStreamConnection_kafkaNetworkingVPC(t *testing.T) {
},
{
Config: kafkaStreamConnectionConfig(projectID, instanceName, "user", "rawpassword", "localhost:9092", "earliest", kafkaNetworkingVPC, true),
Check: resource.ComposeAggregateTestCheckFunc(kafkaStreamConnectionAttributeChecks(
Check: resource.ComposeAggregateTestCheckFunc(DummySleep, kafkaStreamConnectionAttributeChecks(
resourceName, instanceName, "user", "rawpassword", "localhost:9092", "earliest", true, true),
resource.TestCheckResourceAttr(resourceName, "networking.access.type", networkingTypeVPC),
resource.TestCheckResourceAttr(resourceName, "networking.access.name", networkingNameVPC)),
Expand Down
Loading