Skip to content

Documentation Improvements and New Guide for 0.6.0 #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2020

Conversation

themantissa
Copy link
Collaborator

@themantissa themantissa commented Jun 8, 2020

Description

Improvements/fixes to the following:

  • Main page, added info and links to doc for programmatic API keys Updating Snapshot Backup Policy: This resource requires access through a whitelist of ip ranges. #235
  • Clusters Resource - general fixes/improvements
  • Network Containers and Peering - clarified purpose, examples and fixed bugs
  • Updated doc to reflect new terms:
    Cloud Provider Snapshots now Cloud Backup.
    Cloud Provider Snapshots with Point in Time Restore now Continuous Cloud Backup.
    Previous Continuous backup now Legacy Backup
  • Encryption at rest, clarified only needed for BYOK.
  • Teams, example usernames now email addresses
  • Adds Guides section
  • Adds guide for 0.6.0 upgrade needs

Link to any related issue(s):
https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/235

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • [N/A] I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • [N/A] I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Improvements to the following:
* Main page, added info and links to doc for programmatic API keys
* Clusters Resource - general fixes/improvements
* Network Containers and Peering - clarified purpose, examples and fixed bugs
* Cloud Provider Snapshots - now Cloud Backup, continuous backup is now legacy backup.  Updated documentation to reflect that.
* Encryption at rest, clarified only needed for BYOK.
*Adds Guides section
*Adds guide for 0.6.0 upgrade needs
@themantissa
Copy link
Collaborator Author

@gmlp this should knock out the same as https://github.com/terraform-providers/terraform-provider-mongodbatlas/pull/239.

@shum @PacoDw @coderGo93 and @gmlp - I know this is a big PR but if you all can look over what you are most familiar with to give it a sanity check I'd appreciate it. A lot of fixes based on helping customers and the guide is all in here.

Cleaned up a bit.
fix guide, clusters, peering, containers.
@themantissa
Copy link
Collaborator Author

@gmlp latest commit thanks to you - saved me from some terrible formatting there!

Copy link
Contributor

@gmlp gmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! 👍

Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thank you so much it's a great job 👍

@themantissa themantissa merged commit 70cfe1e into master Jun 11, 2020
@themantissa themantissa mentioned this pull request Jun 11, 2020
10 tasks
@themantissa themantissa deleted the multiple-docs-improvements branch July 27, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants