-
Notifications
You must be signed in to change notification settings - Fork 190
feat: Adds support for OIDC WORKLOAD
IdP type to federated_settings_identity_provider
#2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WORKLOAD
to federated_settings_identity_provider
WORKLOAD
IdP type to federated_settings_identity_provider
1572f05
to
011a931
Compare
APIx bot: a message has been sent to Docs Slack channel |
.../federatedsettingsidentityprovider/data_source_federated_settings_identity_providers_test.go
Show resolved
Hide resolved
...rnal/service/federatedsettingsidentityprovider/model_federated_settings_identity_provider.go
Show resolved
Hide resolved
@@ -375,6 +376,7 @@ func TestFlattenFederatedSettingsIdentityProvider(t *testing.T) { | |||
"user_claim": nilStringPtr, | |||
"description": &description, | |||
"authorization_type": nilStringPtr, | |||
"idp_type": conversion.StringPtr(federatedsettingsidentityprovider.WORKFORCE), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be irrelevant, but should we have WORKLOAD somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the model methods there isn't any kind of validation of the values, so I think it's okay to not test different values for idp_type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Adds support for OIDC Workload IdPs for
mongodbatlas_federated_settings_identity_provider
Link to any related issue(s): CLOUDP-250915
Type of change:
Required Checklist:
Further comments