Skip to content

feat: Adds support for OIDC WORKLOAD IdP type to federated_settings_identity_provider #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 3, 2024

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented May 29, 2024

Description

Adds support for OIDC Workload IdPs for mongodbatlas_federated_settings_identity_provider

Link to any related issue(s): CLOUDP-250915

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert changed the base branch from master to CLOUDP-250914_workforce_oidc May 29, 2024 16:04
Base automatically changed from CLOUDP-250914_workforce_oidc to master May 31, 2024 10:26
@oarbusi oarbusi changed the title feat: Adds support for idp_type = WORKLOAD to federated_settings_identity_provider feat: Adds support for OIDC WORKLOAD IdP type to federated_settings_identity_provider May 31, 2024
@EspenAlbert EspenAlbert force-pushed the CLOUDP-250915_oidc_workload branch from 1572f05 to 011a931 Compare May 31, 2024 10:51
@oarbusi oarbusi marked this pull request as ready for review May 31, 2024 12:32
@oarbusi oarbusi requested review from a team as code owners May 31, 2024 12:32
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

@@ -375,6 +376,7 @@ func TestFlattenFederatedSettingsIdentityProvider(t *testing.T) {
"user_claim": nilStringPtr,
"description": &description,
"authorization_type": nilStringPtr,
"idp_type": conversion.StringPtr(federatedsettingsidentityprovider.WORKFORCE),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be irrelevant, but should we have WORKLOAD somewhere?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the model methods there isn't any kind of validation of the values, so I think it's okay to not test different values for idp_type

Copy link
Contributor

@erabil-mdb erabil-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EspenAlbert EspenAlbert merged commit b5c731e into master Jun 3, 2024
32 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-250915_oidc_workload branch June 3, 2024 07:42
svc-apix-Bot added a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants