Skip to content

Fix: improved validation to avoid error 404 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fix: improved validation to avoid error 404 #203

merged 1 commit into from
Apr 23, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Apr 22, 2020 •
edited by marinsalinas
Loading

closes #200

@ghost ghost added the size/XS label Apr 22, 2020
@PacoDw PacoDw mentioned this pull request Apr 22, 2020
Closed
themantissa
themantissa reviewed Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question in comment - let me know your thoughts @PacoDw .

themantissa
themantissa reviewed Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@PacoDw PacoDw changed the title WIP: improved validation to avoid error 404 Fix: improved validation to avoid error 404 Apr 22, 2020
@PacoDw PacoDw requested a review from themantissa April 22, 2020 23:52
themantissa
themantissa approved these changes Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry didn't realize there was a new commit!

@marinsalinas marinsalinas merged commit a437155 into master Apr 23, 2020
@themantissa themantissa deleted the fix-#200 branch August 19, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

terraform plan and apply fails after upgrading this module to 0.5.0
3 participants
@PacoDw @marinsalinas @themantissa