feat: Adds support for region & customer_endpoint_dns_name in privatelink

[EspenAlbert]

Description

Adds support for region & customer_endpoint_dns_name in privatelinkendpointservicedatafederationonlinearchive.
Also, enables editing of the comment attribute.

Link to any related issue(s): CLOUDP-229354
GH Issue: #1878

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contribution guidelines
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
• If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Minimal setup for testing manually:

variable "project_id" {
  type = string
}

variable "vpc_id" {
  type = string 
}

variable "subnet_ids" {
  type = list(string)
}
variable "security_group_ids" {
  type = list(string)
}

resource "aws_vpc_endpoint" "vpce_east" {
  vpc_id             = var.vpc_id
  service_name       = "com.amazonaws.vpce.us-east-1.vpce-svc-0a7247db33497082e" #see screenshot below
  vpc_endpoint_type  = "Interface"
  subnet_ids         = var.subnet_ids
  security_group_ids = var.security_group_ids
}

resource "mongodbatlas_privatelink_endpoint_service_data_federation_online_archive" "test" {
  project_id    = var.project_id
  endpoint_id   = aws_vpc_endpoint.vpce_east.id
  provider_name = "AWS"

  comment       = "Terraform Acceptance Test Manual"
  region        = "US_EAST_1"
  customer_endpoint_dns_name = aws_vpc_endpoint.vpce_east.dns_entry[0].dns_name
}
output "vpc_endpoint_id" {
  value = aws_vpc_endpoint.vpce_east.id
}

How to find the service_name:

After creating the resource in the Atlas UI:

Running CI tests locally:

export MONGODB_ATLAS_LAST_VERSION="1.15.1"
export MONGODB_ATLAS_PRIVATE_ENDPOINT_ID={OUTPUTS.vpc_endpoint_id}
go test -timeout 2400s -run ^(TestAccNetworkPrivatelinkEndpointServiceDataFederationOnlineArchivesDSPlural_basic|TestAccMigrationNetworkPrivatelinkEndpointServiceDataFederationOnlineArchive_basic|TestAccNetworkPrivatelinkEndpointServiceDataFederationOnlineArchive_basic|TestAccNetworkPrivatelinkEndpointServiceDataFederationOnlineArchive_updateComment|TestAccNetworkPrivatelinkEndpointServiceDataFederationOnlineArchive_basicWithRegionDnsName|TestAccNetworkPrivatelinkEndpointServiceDataFederationOnlineArchiveDS_basic)$ github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservicedatafederationonlinearchive -count=1 -v

[lantoli]

LGTM, just a couple of minor comments

[Zuhairahmed]

Left a few comments, questions, and made a few commits directly to this PR. I don't need to review again, overall great first PR @EspenAlbert!

[maastha]

LGTM

[lantoli]

knitpit: i would change this comment as it's in the example folder and it's intended to be used by customers as a template, e.g.: "Example of data federation online archive"

[EspenAlbert]

Updated in d62a3ae 👍