Skip to content

chore: update Changelog file for v0.5.0 version #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

marinsalinas
Copy link
Contributor

No description provided.

@ghost ghost added the size/S label Apr 21, 2020
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few closed issues to remove and one move, one comment. Thank you!

CHANGELOG.md Outdated
**Closed issues:**

- Problem using Cross Region Replica Set in GCP [\#188](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/188)
- Delete this please. [\#187](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/187)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line 14 - "Delete this please. #187"

CHANGELOG.md Outdated
- Problem using Cross Region Replica Set in GCP [\#188](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/188)
- Delete this please. [\#187](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/187)
- Confusing output when modifying a cluster [\#186](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/186)
- Cluster auto-scaling [\#182](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/182)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 16, not added yet, just moved to our feature request site - "Cluster auto-scaling #182
"

CHANGELOG.md Outdated

- Problem using Cross Region Replica Set in GCP [\#188](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/188)
- Delete this please. [\#187](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/187)
- Confusing output when modifying a cluster [\#186](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/186)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 15 - support issue unrelated to release"Confusing output when modifying a cluster #186"

CHANGELOG.md Outdated
- Confusing output when modifying a cluster [\#186](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/186)
- Cluster auto-scaling [\#182](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/182)
- Docs with wrong resource type [\#175](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/175)
- On upgrade from 0.4.1 to 0.4.2 start getting errors [\#174](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/174)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete 18 - did not address in this release (and explained why may not be able to) "On upgrade from 0.4.1 to 0.4.2 start getting errors #174"

CHANGELOG.md Outdated
- Cluster auto-scaling [\#182](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/182)
- Docs with wrong resource type [\#175](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/175)
- On upgrade from 0.4.1 to 0.4.2 start getting errors [\#174](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/174)
- Can't create SYSTEM\_NORMALIZED\_CPU\_IOWAIT alert [\#172](https://github.com/terraform-providers/terraform-provider-mongodbatlas/issues/172)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line 19 - Not fixable via terraform - "Can't create SYSTEM_NORMALIZED_CPU_IOWAIT alert #172"

@ghost ghost added size/XS and removed size/S labels Apr 21, 2020
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty! Let's ask HashiCorp to release tomorrow in the morning if that works for you all.

@marinsalinas marinsalinas merged commit 0a9e96e into master Apr 21, 2020
@marinsalinas marinsalinas deleted the chore/changelogv0.5.0 branch April 21, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants