-
Notifications
You must be signed in to change notification settings - Fork 190
doc: Change documentation for new attributes to support OIDC Identity providers #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- HTTP POST | ||
- HTTP REDIRECT | ||
* `response_signature_algorithm` - (Required) Signature algorithm that Federated Authentication uses to encrypt the identity provider signature. Valid values include SHA-1 and SHA-256. | ||
* `response_signature_algorithm` - Signature algorithm that Federated Authentication uses to encrypt the identity provider signature. Valid values include SHA-1 and SHA-256. | ||
* `protocol` - The protocol of the identity provider. Either SAML or OIDC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it would be good in each attribute to say if it's mandatory depending on the protocol. like... this is mandatory for SAML protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe required would not be the right word, since it's not actually required, I'm not sure about it. I'm open to opinions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions. In general, literal values should be in backticks throughout.
website/docs/d/federated_settings_identity_provider.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/federated_settings_identity_providers.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/federated_settings_identity_provider.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/federated_settings_identity_provider.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/federated_settings_identity_provider.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/federated_settings_identity_provider.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/federated_settings_identity_provider.html.markdown
Outdated
Show resolved
Hide resolved
Co-authored-by: pierwill <[email protected]>
…down Co-authored-by: pierwill <[email protected]>
Co-authored-by: pierwill <[email protected]>
Co-authored-by: pierwill <[email protected]>
Co-authored-by: pierwill <[email protected]>
Co-authored-by: pierwill <[email protected]>
Co-authored-by: pierwill <[email protected]>
Co-authored-by: pierwill <[email protected]>
website/docs/r/federated_settings_identity_provider.html.markdown
Outdated
Show resolved
Hide resolved
Co-authored-by: Agustin Bettati <[email protected]>
Description
Change in docs to add details about new attributes added to federated_settings_identity_provider to support OIDC IdPs
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-220800
Type of change:
Required Checklist:
Further comments