-
Notifications
You must be signed in to change notification settings - Fork 190
Cloud Provider Snapshot Backup Policy #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
56530a9
to
755e9f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool in how it flows - made some comments in that this policy only applies for cloud provider snapshots so I think we need some logic not compute if provider_backup_enabled isn't true.
mongodbatlas/resource_mongodbatlas_cloud_provider_snapshot_backup_policy.go
Outdated
Show resolved
Hide resolved
mongodbatlas/resource_mongodbatlas_cloud_provider_snapshot_backup_policy.go
Show resolved
Hide resolved
website/docs/d/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh hit wrong radio buttons - from the approve comment - This is really cool in how it flows - made some comments in that this policy only applies for cloud provider snapshots so I think we need some logic to not compute if provider_backup_enabled isn't true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responded to a few of the questions. I think we are getting there!
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 thing that got missed a few times.
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thank you :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ource into the plugin
47f761f
to
37e0fb5
Compare
Added:
mongodbatlas_cloud_provider_snapshot_backup_policy
resource.mongodbatlas_cloud_provider_snapshot_backup_policy
resource acceptance testing.mongodbatlas_cloud_provider_snapshot_backup_policy
resource website documentation.mongodbatlas_cloud_provider_snapshot_backup_policy
data source.mongodbatlas_cloud_provider_snapshot_backup_policy
data source acceptance testing.mongodbatlas_cloud_provider_snapshot_backup_policy
data source website documentation.Example Usage
Also, we added a new parameter for the cluster resource and data sources
snapshot_backup_policy
, it represents the cloud provider snapshot backup policy for the created cluster. It's a computed attribute so to get all backup policies information the cluster must enable theprovider_backup_enabled
orbackup_enabled
depending on the mongo version.Note the above configuration on how to get each policy item id to modify them.