-
Notifications
You must be signed in to change notification settings - Fork 190
test: including unit testing for search deployments state transition logic and model conversions #1653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mongodbatlas/fw_resource_mongodbatlas_search_deployment_model_test.go
Outdated
Show resolved
Hide resolved
mongodbatlas/fw_resource_mongodbatlas_search_deployment_model_test.go
Outdated
Show resolved
Hide resolved
mongodbatlas/fw_resource_mongodbatlas_search_deployment_model_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments that are not blocking the PR
mongodbatlas/fw_resource_mongodbatlas_search_deployment_state_transition_test.go
Outdated
Show resolved
Hide resolved
mongodbatlas/fw_resource_mongodbatlas_search_deployment_state_transition_test.go
Outdated
Show resolved
Hide resolved
mongodbatlas/fw_resource_mongodbatlas_search_deployment_model_test.go
Outdated
Show resolved
Hide resolved
mongodbatlas/fw_resource_mongodbatlas_search_deployment_model_test.go
Outdated
Show resolved
Hide resolved
mongodbatlas/fw_resource_mongodbatlas_search_deployment_model_test.go
Outdated
Show resolved
Hide resolved
mongodbatlas/fw_resource_mongodbatlas_search_deployment_state_transition_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - approve to unblock
…logic and model conversions adjusting to new file structure
da41ef6
to
76f9da6
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
Description
Jira ticket: INTMDB-1309
Adds unit testing for search_deployment resource. As part of this the following tests were defined:
Type of change:
Required Checklist:
Further comments