chore: migrate alert_configuration to new SDK #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
reviewed
Nov 16, 2023
lantoli
reviewed
Nov 16, 2023
lantoli
approved these changes
Nov 16, 2023
| apiReq := &matlas.AlertConfiguration{ | ||
| EventTypeName: alertConfigPlan.EventType.ValueString(), | ||
| apiReq := &admin.GroupAlertsConfig{ | ||
| EventTypeName: alertConfigPlan.EventType.ValueStringPointer(), |
There was a problem hiding this comment.
curious why SDK is generating this field as optional (string pointer) when it is required for all cases. (does not block PR, just something that could be worth investigating to gain more understanding in sdk side)
There was a problem hiding this comment.
is the "required" info in OpenAPI or it's just how the server behaves?
There was a problem hiding this comment.
was observing from the API docs, which reflect the API Spec (https://www.mongodb.com/docs/atlas/reference/api-resources-spec/v2/#tag/Alert-Configurations/operation/createAlertConfiguration)
|
Let's wait to merge this until we release 1.13.0! see my comment in Jira |
|
AgustinBettati
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate alert_configuration to new SDK.
The existing tests already cover all behaviours of the resource, so no tests have been added.
Link to any related issue(s):
https://jira.mongodb.org/browse/INTMDB-1121
Type of change:
Required Checklist:
Further comments