Skip to content

fix: Fixes search index acceptance tests flow #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 9, 2023
Merged

fix: Fixes search index acceptance tests flow #1610

merged 25 commits into from
Nov 9, 2023

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Nov 8, 2023 •
edited
Loading

Description

Jira ticket: INTMDB-1271

Fixes search index acceptance tests flow.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@lantoli lantoli changed the title fix: Fixes file change detection for search index acceptance tests fix: Fixes search index acceptance tests flow Nov 8, 2023
@lantoli lantoli marked this pull request as ready for review November 8, 2023 20:56
@lantoli lantoli requested a review from a team as a code owner November 8, 2023 20:56
@lantoli lantoli marked this pull request as draft November 9, 2023 05:31
andreaangiolillo
andreaangiolillo reviewed Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68% ➖
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 17% ❌
Summary 3% (272 / 10332) ❌

@lantoli lantoli marked this pull request as ready for review November 9, 2023 12:00
@andreaangiolillo andreaangiolillo requested a review from a team November 9, 2023 12:04
andreaangiolillo
andreaangiolillo approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the discussion

@lantoli lantoli merged commit 1b942e4 into master Nov 9, 2023
@lantoli lantoli deleted the INTMDB-1271_search_index_acc_tests branch November 9, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantoli @andreaangiolillo