-
Notifications
You must be signed in to change notification settings - Fork 190
feat: set format for AWS region value in the provider definition #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcosuma
merged 6 commits into
master
from
INTMDB-1034-fix-aws-region-env-variable-bug
Oct 30, 2023
Merged
feat: set format for AWS region value in the provider definition #1549
marcosuma
merged 6 commits into
master
from
INTMDB-1034-fix-aws-region-env-variable-bug
Oct 30, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
reviewed
Oct 25, 2023
lantoli
reviewed
Oct 25, 2023
lantoli
approved these changes
Oct 25, 2023
11 tasks
lantoli
reviewed
Oct 26, 2023
…with an AWS Role (#1551) * set all possible default values taken from environment varialbes (if exist). * addresses comments. * feat: adds test coverage for AWS Role Authentication (#1552) * adds test coverage. * pre-check that regular credentials env variables are not set. * feat: adds test infrastructure to run acceptance tests on PRs (#1553) * adds test infra. * fix. * Update mongodbatlas/provider.go Co-authored-by: Leo Antoli <[email protected]> * Update mongodbatlas/provider.go Co-authored-by: Leo Antoli <[email protected]> * addresses comments. --------- Co-authored-by: Leo Antoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When authenticating with an
aws_role
(see example below), the AWS region value must be lowercase and with-
symbol. Considering that we allow to consume the region value also from environment variables and that it is generally allowed to have multiple ways to identify the region (e.g. in MongoDB Atlas we use the convention US_EAST_1 instead of us-east-1), this change make sure that the region value is always converted to its right format.Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-1034
Type of change:
Required Checklist:
Further comments