Skip to content

fix: handle incorrect ids when importing alert_configuration or project_ip_access_list resources #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2023
Merged

fix: handle incorrect ids when importing alert_configuration or project_ip_access_list resources #1472

merged 4 commits into from
Sep 15, 2023

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Sep 14, 2023 •
edited
Loading

Description

Ticket: INTMDB-1113

  • Handle incorrect ids when importing alert_configuration or project_ip_access_list resources.
  • Minor fix in error handling for project data source read.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@lantoli lantoli requested a review from a team as a code owner September 14, 2023 16:48
@lantoli lantoli added the bug label Sep 14, 2023
AgustinBettati
AgustinBettati approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing comments

@lantoli lantoli merged commit cfacdb3 into master Sep 15, 2023
@lantoli lantoli deleted the INTMDB-1113_import branch September 15, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@AgustinBettati AgustinBettati AgustinBettati approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lantoli @gssbzn @AgustinBettati