-
Notifications
You must be signed in to change notification settings - Fork 190
feat: Parameter Add: OIDC Database Users #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Aug 11, 2023
gssbzn
approved these changes
Aug 11, 2023
Co-authored-by: Gustavo Bazan <[email protected]>
AgustinBettati
approved these changes
Aug 14, 2023
Zuhairahmed
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments. Nice! Customers are going to love this one
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
…ngodbatlas into INTMDB-931
zach-carr
reviewed
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retroactively commenting - this looks good copy-wise 👍
andreaangiolillo
added a commit
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for OIDC federated authentication user
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments
FYI: We cannot define an acceptance test because we need to set a federation authentication sets in the Org
Testing
I tested my changes locally by building the provider binary with my changes.
TF Configuration
terraform plan|apply|destroy
Terraform state