INTMDB-436: Update privatelink endpoint service resources timeout config #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...dbatlas/resource_mongodbatlas_privatelink_endpoint_service_data_federation_online_archive.go
Show resolved
Hide resolved
Zuhairahmed
approved these changes
Jul 20, 2023
| @@ -182,7 +183,7 @@ func resourceMongoDBAtlasPrivateLinkEndpointServerlessDelete(ctx context.Context | |||
| Refresh: resourcePrivateLinkEndpointServerlessRefreshFunc(ctx, conn, projectID, instanceName, endpointID), | |||
| Timeout: d.Timeout(schema.TimeoutDelete), | |||
| MinTimeout: 5 * time.Second, | |||
| Delay: 3 * time.Second, | |||
| Delay: 5 * time.Second, | |||
There was a problem hiding this comment.
just curious, why 5 seconds delay?
There was a problem hiding this comment.
@Zuhairahmed just making it consistent across privatelink_endpoint resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable configurable timeout, and make consistent 2 hour defaulting timeout across dedicated, serverless, and privatelink_endpoint_service_data_federation_online_archive
Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-436
Type of change:
Required Checklist:
Further comments