Skip to content

Encryption At Rest: fixed issues and added an enhancement #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 18, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Feb 10, 2020

closes: #74 , #80 , #93

Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM!

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling/grammar and a comment. Otherwise LGTM.

@PacoDw PacoDw requested a review from themantissa February 12, 2020 18:25
@themantissa
Copy link
Collaborator

LGTM, thanks!

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, sorry forgot to change to Approve, not just comment - now approved :) thanks!

@rvdh
Copy link

rvdh commented Feb 18, 2020

When can we expect this to be merged into a release? We're running into this issue and now it's not possible to update the encryption at rest key without recreating the whole cluster.

@marinsalinas marinsalinas merged commit 81ddd75 into master Feb 18, 2020
@marinsalinas marinsalinas deleted the fix-#80 branch February 18, 2020 15:01
@themantissa
Copy link
Collaborator

@rvdh barring any last minute issues we plan to release 0.4.0 today. We'll be posting two blogs and I'll link them in the issues section once live as one is an upgrade guide regarding the Project IP Whitelist changes.

In between releases please feel free to beta coming changes by building from the master branch. Instructions are in the README file.

@rvdh
Copy link

rvdh commented Feb 18, 2020

@themantissa Thats great news! :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash (panic, interface conversion error) when creating mongodbatlas_encryption_at_rest in Azure
4 participants