INTMDB-433: make sure failed Terraform run rolls back properly #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
There is one failing test that looks legit 9692262381?pr=1264#step:4:148
Comment on lines
235
to
238
| _, errd := conn.Projects.Delete(ctx, project.ID) | ||
| if errd != nil { | ||
| return diag.Errorf(errorProjectDelete, project.ID, errd) | ||
| } |
There was a problem hiding this comment.
Why can't we use deleteProject() here?
There was a problem hiding this comment.
Modified create to use this function in all delete project requests so that it uses function with timeout
Zuhairahmed
reviewed
Jun 27, 2023
There was a problem hiding this comment.
@martinstibbe can you confirm that no change is required to resource_mongodbatlas_project_test.go?
resource_mongodbatlas_project_test.go no changes needed just deletes project if it fails to create all the additional attached pieces during create i.e. teams/api keys |
Zuhairahmed
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
INTMDB-433: make sure failed Terraform run rolls back properly
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
#700
https://jira.mongodb.org/browse/INTMDB-433
Type of change:
Required Checklist:
Further comments