INTMDB-874: [Terraform] Support transactionLifetimeLimitSeconds parameter in Cluster and Advanced Cluser #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter in Cluster and Advanced Cluser
gssbzn
reviewed
Jun 19, 2023
| @@ -541,7 +541,10 @@ func clusterAdvancedConfigurationSchemaComputed() *schema.Schema { | |||
| }, | |||
| "oplog_min_retention_hours": { | |||
| Type: schema.TypeInt, | |||
| Optional: true, | |||
| Computed: true, | |||
There was a problem hiding this comment.
Optional is not correct here because data sources cannot provide data but only store data coming from the endpoint. The same field for the resource has Optional
Zuhairahmed
approved these changes
Jun 19, 2023
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
gssbzn
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: INTMDB-874
Type of change:
Required Checklist:
Further comments
Testing
TestAccClusterRSCluster_basic_Partial_AdvancedConf
Running tool: /Users/andrea.angiolillo/.asdf/shims/go test -timeout 300000s -run ^TestAccClusterRSCluster_basic_Partial_AdvancedConf$ github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas ok github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 768.171sTestAccClusterAdvancedCluster_advancedConf
Running tool: /Users/andrea.angiolillo/.asdf/shims/go test -timeout 300000s -run ^TestAccClusterAdvancedCluster_advancedConf$ github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas ok github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 1507.143s