INTMDB-249: [Terraform] Lint and fix linting for examples

[andreaangiolillo]

Description

Ticket: INTMDB-249
This PR updates the example action to use the tflint.sh script and fixed linting errors

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contribution guidelines
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code

Further comments

[gssbzn]

is this working? one of the reasons it was commented was because of the number of errors found

[andreaangiolillo]

This is the action 9408128097: looking at the log it seems working. I will add a fmt error to one of terraform file and see if it fails

[andreaangiolillo]

I have divided the original job into two separate jobs, each with a specific purpose:

• tf-validate:
  • This job executes three Terraform commands: terraform init, terraform fmt, and terraform validate
  • It is necessary to replace the provider with mongodbatlas-dev in this job. This is because new resources are not available until the next release.
  • It is important to note that when using mongodbatlas-dev as the provider, the version attribute cannot be specified for the dev provider. However, tflint mandates that the version must be set for all providers in the Terraform configuration. This discrepancy is the reason for dividing the initial job.
• tflint: this job runs tflint

[andreaangiolillo]

updated tflint to latest version

[Zuhairahmed]

Looks like only versions.tf and variables.tf files had updates. Surprised there were no linting issues with any of the main.tf files in examples, is this just a coincidence?

[andreaangiolillo]

@Zuhairahmed We were already running terraform init, terraform fmt and terraform validate for all the examples. See examples.yml#L54

[gssbzn]

Thanks for all the fixes