Database users: added x509_type attribute #122
Conversation
ghost
added
… due to this change in the resource
…tribute and refactored the code due to this change in the singular datasource
| "database_name": databaseName, | ||
| "project_id": projectID, | ||
| "username": username, | ||
| "auth_database_name": databaseName, |
There was a problem hiding this comment.
I think this is a lot clearer as some found this confusing, thank you! Is there any way to still support the old database_name as well without getting too messy? If not then we'll need to be sure to log this as a breaking change in the Changelog, Fyi @marinsalinas
There was a problem hiding this comment.
I think that it is a breaking change, what do you think @marinsalinas ?
There was a problem hiding this comment.
Also the little change in the client breaked up all :S
There was a problem hiding this comment.
Oh no, if it's breaking too much we should just leave it as is then, sorry to suggest it as didn't think about how much impact it has and we are already short on time. Let's just revert this and save the headache.
There was a problem hiding this comment.
It's okay it breaks a little bit but with this PR all the breaking changes are fixed
…tribute and refactored the code due to this change in plural datasource chore: changed database_name to auth_database_name
chore: updated go mod
Added:
x509_typeattribute was added in the resource and the data source in the database resource, this allows us to configure it with the future X509 resource.x509_typeis enabled the database name must be$externaland to be able to Get or Delete it we need to pass the database name to avoid errors.