Skip to content

INTMDB-725 pit enabled #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 28, 2023
Merged

INTMDB-725 pit enabled #1151

merged 14 commits into from
Apr 28, 2023

Conversation

martinstibbe
Copy link
Contributor

@martinstibbe martinstibbe commented Apr 28, 2023 •
edited
Loading

Description

Fix missing parameter mapping discovered via testing

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@martinstibbe martinstibbe requested a review from a team as a code owner April 28, 2023 14:39
@Zuhairahmed Zuhairahmed self-requested a review April 28, 2023 14:44
Zuhairahmed
Zuhairahmed approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zuhairahmed Zuhairahmed merged commit 436bbf7 into master Apr 28, 2023
@martinstibbe martinstibbe deleted the INTMDB-725-pit-enabled branch June 15, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinstibbe @Zuhairahmed