Skip to content

Fix #68: Added the ability to re-create the whitelist entry when it's remove manually #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2020
Merged

Fix #68: Added the ability to re-create the whitelist entry when it's remove manually #106

merged 2 commits into from
Jan 31, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Jan 15, 2020

  • Also, the export function was added due that it before doesn't work well

closes #68

@ghost ghost added the size/S label Jan 15, 2020
@PacoDw PacoDw mentioned this pull request Jan 15, 2020
Closed
themantissa
themantissa approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marinsalinas
marinsalinas approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PacoDw PacoDw merged commit 1597616 into master Jan 31, 2020
@PacoDw PacoDw deleted the fix-#68 branch January 31, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa approved these changes

@shum shum Awaiting requested review from shum

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whitelisted Project IPs when manually deleted causes failure at next plan/apply
3 participants
@PacoDw @marinsalinas @themantissa