Skip to content

Added functions to handle labels attribute in some resources #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2020
Merged

Added functions to handle labels attribute in some resources #101

merged 1 commit into from
Feb 3, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Jan 6, 2020

  • The functions were moved on to be reused by other resources like clusters and database users.

@ghost ghost added size/S and removed size/M labels Jan 11, 2020
@marinsalinas
Copy link
Contributor

Hello @PacoDw , it seems like the following functions are unused.

mongodbatlas/provider.go:208:6: func `expandLabelSliceFromSetSchema` is unused (unused)
mongodbatlas/provider.go:197:6: func `flattenLabels` is unused (unused)`

@PacoDw
Copy link
Contributor Author

PacoDw commented Jan 17, 2020

Hi @marinsalinas these functions were reused in two files, for this reason, I decided to make an independent file with these changes and I based on this branch to create those PR's (https://github.com/terraform-providers/terraform-provider-mongodbatlas/pull/100, https://github.com/terraform-providers/terraform-provider-mongodbatlas/pull/102)

@themantissa
Copy link
Collaborator

Please also have Marin check again before merging. Thanks!

@ghost ghost added size/XS and removed size/S labels Jan 31, 2020
@PacoDw PacoDw merged commit 90d6beb into master Feb 3, 2020
@PacoDw PacoDw deleted the labels_func branch February 3, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa approved these changes

@shum shum Awaiting requested review from shum

Assignees
No one assigned
Labels
dependencies size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PacoDw @marinsalinas @themantissa