Skip to content

AWS clusters default provider_encrypt_ebs_volume to false #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattt416 opened this issue Sep 26, 2019 · 4 comments · Fixed by #45
Closed

AWS clusters default provider_encrypt_ebs_volume to false #40

mattt416 opened this issue Sep 26, 2019 · 4 comments · Fixed by #45

Comments

@mattt416
Copy link
Contributor

Hey folks,

If I omit provider_encrypt_ebs_volume in my resource definition for an AWS cluster, this value defaults to false. However, the Atlas API defaults this to true.

I think it would also be beneficial to remove provider_encrypt_ebs_volume: false from the Example AWS cluster in the mongodbatlas_cluster docs as encrypting your volume is the preferred config.

Thanks!

@themantissa
Copy link
Collaborator

@mattt416 agreed. @marinsalinas / @PacoDw can we get this corrected to the same default as the underlying system?

@PacoDw
Copy link
Contributor

PacoDw commented Oct 3, 2019

Hello, @mattt416 the fix is on the fix-#40 branch, could you plz check if this was resolved?

If you have another comment plz let us know, thanks!

marinsalinas added a commit that referenced this issue Oct 8, 2019
fix-#40: added true value by defualt on provider_encrypt_ebs_volume attr
@mattt416
Copy link
Contributor Author

@PacoDw Apologies for delayed reply, was away on vacation when you posted your previous comment. I've since tested this (using 0.3.0 release) and all looks good. Thank you!

@PacoDw
Copy link
Contributor

PacoDw commented Oct 23, 2019

@mattt416 Don't worry about it :) I'm glad that everything is okay for you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants