Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix coverage downloading perf results #4501

Merged
merged 2 commits into from
Apr 8, 2025
Merged

chore: fix coverage downloading perf results #4501

merged 2 commits into from
Apr 8, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 7, 2025

Description

What is changing?

Performance uploads to the same place as coverage and coverage downloads everything

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review April 7, 2025 19:47
@nbbeeken nbbeeken requested a review from a team as a code owner April 7, 2025 19:47
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh those pesky benchmarks. Nice catch.

@durran durran merged commit 41dce2a into main Apr 8, 2025
2 of 3 checks passed
@durran durran deleted the fix-coverage branch April 8, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants