Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(NODE-6860): add logging for known flaky tests #4496

Merged
merged 13 commits into from
Apr 8, 2025
Merged

ci(NODE-6860): add logging for known flaky tests #4496

merged 13 commits into from
Apr 8, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 1, 2025

Description

What is changing?

  • unskip flaky tests
  • add logging collection
Is there new documentation needed for these changes?

No

What is the motivation for this change?

When a test flakes we should get more insight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-6860-flaky-logging branch 2 times, most recently from 3171e02 to 3bb8041 Compare April 2, 2025 17:35
@nbbeeken nbbeeken force-pushed the NODE-6860-flaky-logging branch from 3bb8041 to 2be5714 Compare April 2, 2025 18:52
@nbbeeken nbbeeken marked this pull request as ready for review April 3, 2025 20:06
@nbbeeken nbbeeken requested a review from a team as a code owner April 3, 2025 20:06
@nbbeeken
Copy link
Contributor Author

nbbeeken commented Apr 3, 2025

Example of the logs being printed: https://parsley.mongodb.com/evergreen/mongo_node_driver_next_rhel80_large_Node20_test_8.0_replica_set_patch_9111f98cadcb594ab7c4fd3161f2f6e42105f917_67eecac9e10ab70007680e9a_25_04_03_17_52_20/0/task?bookmarks=0,9706&shareLine=1945

@baileympearson baileympearson self-assigned this Apr 3, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 3, 2025
baileympearson
baileympearson requested changes Apr 3, 2025
View reviewed changes
baileympearson
baileympearson requested changes Apr 4, 2025
View reviewed changes
@nbbeeken nbbeeken requested a review from baileympearson April 4, 2025 15:04
baileympearson
baileympearson requested changes Apr 4, 2025
View reviewed changes
@nbbeeken nbbeeken requested a review from baileympearson April 4, 2025 17:38
@nbbeeken nbbeeken requested a review from baileympearson April 7, 2025 21:41
@baileympearson baileympearson merged commit 46cb56d into main Apr 8, 2025
30 checks passed
@baileympearson baileympearson deleted the NODE-6860-flaky-logging branch April 8, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson