Skip to content

Fix inventory file and upgrade documentation #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

mateigrigore
Copy link
Contributor

Summary:

This PR will improve the setup process for local development of the mongodb-kubernetes-operator. The documentation contained outdated and misleading information. Also some problems with building images and deploying the operator were encountered because of using a local registry. This

The PR adds:

  • Documentation changes to improve the local setup process
  • Changes to the Makefile:
    • Change the name of the parameter to look for the agent image in the config.json file to agent_image
    • Add --ignore-not-found flag to uninstall-crd target because of errors encountered when calling this during the make deploy command where no crd was installed yet
    • Add $(IMG_BUILD_ARGS) to all image building targets to allow the --insecure flag to be passed as a paramter
  • Changes to the inventory.yaml file:
    • Removed default values for agent_distro and tools_distro
    • Changed the values for agent_distro and tools_distro in buildargs to be extracted from the params
  • Changes to the pipeline.py file:
    • Allow for a new argument insecure to be passed

All Submissions:

  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@nammn nammn added the safe-to-test Add this label to PRs from forks to trigger E2E tests label Jul 23, 2024
@nammn nammn merged commit 57708bd into mongodb:master Jul 23, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Add this label to PRs from forks to trigger E2E tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants