-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4112 Revert to testing with pymongocrypt@master #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.evergreen/run-tests.sh
Outdated
@@ -136,6 +136,10 @@ if [ -n "$TEST_ENCRYPTION" ] || [ -n "$TEST_FLE_AZURE_AUTO" ] || [ -n "$TEST_FLE | |||
exit 1 | |||
fi | |||
export PYMONGOCRYPT_LIB | |||
|
|||
# TODO: Test with 'pip install pymongocrypt' | |||
git clone https://github.com/mongodb/libmongocrypt.git libmongocrypt_git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I originally had in #1477 that we removed was:
if [ ! -d "libmongocrypt_git" ]; then
git clone https://github.com/mongodb/libmongocrypt.git libmongocrypt_git
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add that back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please, it errors on subsequent runs otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes these failures:
https://spruce.mongodb.com/task/mongo_python_driver_tests_python_version_rhel8_test_encryption__platform~rhel8_auth_ssl~noauth_nossl_python_version~3.7_encryption~encryption_test_4.2_replica_set_0615df47b5251dc718ef91b24da3efb95d7b4f6f_24_01_30_20_00_24?execution=0&sortBy=STATUS&sortDir=ASC