Skip to content

Allow generic base classes for POJOs #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Jun 18, 2024

This change fixes a regression which prevents the driver from encoding and decoding concrete classes which extend generic base classes, when the base class is specified as the generic type of the MongoCollection.

JAVA-5173

This change fixes a regression which prevents the driver from encoding and decoding
concrete classes which extend generic base classes, when the base class is specified
as the generic type of the MongoCollection.

JAVA-5173
@jyemin jyemin requested a review from rozza June 18, 2024 20:20
@jyemin jyemin self-assigned this Jun 18, 2024
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - suggested a simple check to prevent the recursion.

@jyemin jyemin requested a review from rozza July 2, 2024 19:28
@jyemin jyemin marked this pull request as ready for review July 2, 2024 19:29
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyemin jyemin merged commit 88b4218 into mongodb:master Jul 8, 2024
57 of 59 checks passed
@jyemin jyemin deleted the JAVA-5173 branch July 8, 2024 16:42
jyemin added a commit to jyemin/mongo-java-driver that referenced this pull request Jul 8, 2024
This change fixes a regression which prevents the driver from encoding and decoding
concrete classes which extend generic base classes, when the base class is specified
as the generic type of the MongoCollection.

JAVA-5173

Co-authored-by: Ross Lawley <[email protected]>
jyemin added a commit that referenced this pull request Jul 8, 2024
This change fixes a regression which prevents the driver from encoding and decoding
concrete classes which extend generic base classes, when the base class is specified
as the generic type of the MongoCollection.

JAVA-5173

Co-authored-by: Ross Lawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants